Increase MaxReconnectionAttempts default from 2 to 5#1355
Open
Increase MaxReconnectionAttempts default from 2 to 5#1355
Conversation
Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update MaxReconnectionAttempts to comply with MCP specification
Increase MaxReconnectionAttempts default from 2 to 5
Feb 22, 2026
stephentoub
approved these changes
Feb 22, 2026
Contributor
stephentoub
left a comment
There was a problem hiding this comment.
This is another attempt to fix the sse-retry conformance test failures that continue to plague us in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
MaxReconnectionAttemptsof2is too low for the MCP spec's intended reconnection behavior, where theretryfield—not a count cap—is the intended throttling mechanism. Under CI load, two consecutive transient failures exhaust the budget immediately, causing thesse-retryconformance test to flake.Changes
HttpClientTransportOptions.MaxReconnectionAttempts: Default increased from2→5<value>tag and<remarks>to reflect the new default and clarify that the counter resets to zero on each successful stream read (i.e., only consecutive hard failures count toward the limit)Original prompt
This pull request was created from Copilot chat.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.