refactor(client): migrates CompletableFuture to reactive patterns for HttpClientSseClientTransport#128
Closed
Aliaksie wants to merge 5 commits intomodelcontextprotocol:mainfrom
Conversation
9a72b0f to
a34ca8b
Compare
d5b00c9 to
55c5310
Compare
mcp/src/main/java/io/modelcontextprotocol/client/transport/HttpClientSseClientTransport.java
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/client/transport/HttpClientSseClientTransport.java
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/client/transport/HttpClientSseClientTransport.java
Show resolved
Hide resolved
mcp/src/main/java/io/modelcontextprotocol/client/transport/FlowSseClient.java
Show resolved
Hide resolved
55c5310 to
fcd0d8f
Compare
fcd0d8f to
f72e92b
Compare
Contributor
Author
|
maybe this PR should be some how incorporate into this PR |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced CompletableFuture with Mono from the reactive programming paradigm for the HttpClientSseClientTransport class internally, ensuring a consistent concurrency model using reactive patterns.
Motivation and Context
This change was made to align with a more consistent and modern concurrency implementation, avoiding the mixing of different paradigms. By switching from CompletableFuture to Mono, we improving maintainability and consistency, while also simplifying the concurrency handling for SSE event processing. This PR is related to issue
How Has This Been Tested?
Breaking Changes
No breaking changes should be introduced. The internal concurrency implementation has changed, but it does not affect the end users. No code or configuration updates are needed for consumers of the HttpClientSseClientTransport class.
Types of changes
Checklist
Additional context
let me know if i missed something and need to add or if these changes don't make sense no problem just close this pr :-)