fix: resolve duplicate requests caused by concurrent message sending#333
Closed
JooKS-me wants to merge 2 commits intomodelcontextprotocol:mainfrom
Closed
fix: resolve duplicate requests caused by concurrent message sending#333JooKS-me wants to merge 2 commits intomodelcontextprotocol:mainfrom
JooKS-me wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
8066995 to
5fd0744
Compare
Contributor
|
Nice catch @JooKS-me , thank you. |
Contributor
Author
OK,it's done~ |
tzolov
pushed a commit
that referenced
this pull request
Jun 24, 2025
…333) - Add .copy() call before modifying requestBuilder in FlowSseClient - Add .copy() call before modifying requestBuilder in HttpClientSseClientTransport - Prevents unintended mutations of shared builder instances
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When calling the tools/call method of the same mcp async-client in parallel, we found that the client occasionally sent duplicate messages. We located that the same requestBuilder was used each time a request was made in the SDK, which was thread-unsafe.
How Has This Been Tested?
Breaking Changes
No
Types of changes
Checklist
Additional context