feat: Add error logging for HttpClientSseClientTransport#361
Closed
tiaoc wants to merge 1 commit intomodelcontextprotocol:mainfrom
Closed
feat: Add error logging for HttpClientSseClientTransport#361tiaoc wants to merge 1 commit intomodelcontextprotocol:mainfrom
tiaoc wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
tzolov
added a commit
that referenced
this pull request
Jul 13, 2025
- Include response body in error messages for better debugging - Change sendHttpPost return type from HttpResponse<Void> to HttpResponse<String> - Use BodyHandlers.ofString() instead of discarding response body - Add testErrorOnBogusMessage test to verify error handling for invalid JSON-RPC messages - Test validates that malformed messages return 400 status with descriptive error message Replace #361 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com> Co-authored-by: jkma <jkma@trip.com>
Contributor
|
@tiaoc thanks you for the improvement.
you are are still a co-author |
Contributor
|
Replaced by #391 |
tzolov
added a commit
that referenced
this pull request
Jul 13, 2025
- Include response body in error messages for better debugging - Change sendHttpPost return type from HttpResponse<Void> to HttpResponse<String> - Use BodyHandlers.ofString() instead of discarding response body - Add testErrorOnBogusMessage test to verify error handling for invalid JSON-RPC messages - Test validates that malformed messages return 400 status with descriptive error message Replace #361 Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com> Co-authored-by: jkma <jkma@trip.com>
Author
|
@tzolov Great, thanks for letting me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the HTTP request error handling to now capture and log the response body content (via response.body()) for non-success status codes (non-200/201/202/206), rather than only logging the status code.
Motivation and Context
When a failed status code is received, the response lacks a body, forcing developers to manually reproduce the issue.
How Has This Been Tested?
Constructed an improperly configured HTTP client request builder and verified the log message output via unit testing.
Breaking Changes
Types of changes
Checklist
Additional context
Using ofString() to read the response body aids in troubleshooting server errors, but incurs serialization overhead (even for trivial bodies like "Accepted"). If maintainers reject this change, the method requires a documentation comment instructing developers to manually inspect the response body during debugging.