Support Progress Flow for McpClient#389
Closed
134130 wants to merge 16 commits intomodelcontextprotocol:mainfrom
Closed
Support Progress Flow for McpClient#389134130 wants to merge 16 commits intomodelcontextprotocol:mainfrom
134130 wants to merge 16 commits intomodelcontextprotocol:mainfrom
Conversation
BREAKING : Client Specification record is braking
…Notification to send client progress updates
because of the client code is restored for PR seperation
This was referenced Jul 12, 2025
Closed
Contributor
tzolov
requested changes
Jul 15, 2025
| * @param progressNotification The progress notification to send | ||
| * @return A Mono that completes when the notification has been sent | ||
| */ | ||
| public Mono<Void> progressNotification(McpSchema.ProgressNotification progressNotification) { |
Contributor
There was a problem hiding this comment.
This needs to be mirrored in the McpSyncServerExchange
| import io.modelcontextprotocol.util.Assert; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
| import reactor.util.annotation.Nullable; |
Contributor
There was a problem hiding this comment.
Remove the reactor.util.annotation.Nullable;
Contributor
Author
|
@tzolov Thank you for your comment! Yes, the PR depends on #300 and will be rebased after the #300 is merged. I've tried to separate the PR for Server and Client implementation, as the #298 task list. How do you think about this? Do you think separating the PR is meaningful? And do you want a new PR with closing #300 and #389?
Of course! I see the #392, and I can rework to reduce the changes. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context