fix: SseLineSubscriber will not request after default 256 request#505
Closed
taobaorun wants to merge 3 commits intomodelcontextprotocol:mainfrom
Closed
fix: SseLineSubscriber will not request after default 256 request#505taobaorun wants to merge 3 commits intomodelcontextprotocol:mainfrom
taobaorun wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
Contributor
|
Thanks for addressing this @taobaorun ! |
He-Pin
reviewed
Aug 21, 2025
mcp/src/main/java/io/modelcontextprotocol/client/transport/ResponseSubscribers.java
Outdated
Show resolved
Hide resolved
Contributor
|
@taobaorun i believe this #507 better addresses the issue as it excludes the error case |
Contributor
|
Resolved by #507 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#502
How Has This Been Tested?
Tested 24 hours, Client received all messages.
Breaking Changes
Types of changes
Checklist
Additional context