feat: Add task related things to schema#671
feat: Add task related things to schema#671He-Pin wants to merge 16 commits intomodelcontextprotocol:mainfrom
Conversation
He-Pin
changed the title
|
I will try to implement this internal first, feel free to continue |
|
I would like to add modelcontextprotocol/modelcontextprotocol#1831 to this too |
|
Let's wait until the |
|
I'm ok to just drop it if time is not OK, and at the same time, I'm implementing it first internal too. |
|
Let's park this for now, then. |
|
@Kehrlann Just dropped. |
He-Pin
force-pushed
the
taskHink
branch
8 times, most recently
from
584e4a5 to
8544229
Compare
| @JsonProperty("content") List<Content> content, | ||
| @JsonProperty("isError") Boolean isError, | ||
| @JsonProperty("structuredContent") Object structuredContent, | ||
| @JsonProperty("task") Task task, |
There was a problem hiding this comment.
No | type in Java, so add the task here instead of GetTaskRequest | CallToolResult, an Either type will change much code, and Object loses type safety.
There was a problem hiding this comment.
I was adding a CallToolAuxResult and I found the JSONRPCResponse has a JSONRPCError, so I will follow the same design. it should be JSONRPCResponse | JSONRPCError, but the current shape seems pratical.
He-Pin
force-pushed
the
taskHink
branch
4 times, most recently
from
354d2e2 to
0ff73cb
Compare
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
Signed-off-by: He-Pin <hepin1989@gmail.com>
| */ | ||
| Map<String, Object> meta(); | ||
|
|
||
| sealed interface McpEvent extends McpMessage { |
There was a problem hiding this comment.
Where are these in the spec? I don't find them.
There was a problem hiding this comment.
My current implementation at work is Flux<McpMessage> callToolStream(CallToolRequest request) to support streaming responses. We also have callTool(CallToolRequest request) built upon this implementation.
I specifically plan to support streaming responses in the future. However, because my implementation at work is far more complex than a memory-based implementation, it's not yet ready for open-source development.
Signed-off-by: He-Pin <hepin1989@gmail.com>
3 participants
Motivation and Context
ISSUE: modelcontextprotocol/modelcontextprotocol#1686
PR: modelcontextprotocol/modelcontextprotocol#1732
Issue in Java-sdk : #668
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context