Skip to content

fix: polish SEP-1577 sampling handling#765

Draft
MukundaKatta wants to merge 1 commit into
modelcontextprotocol:mainfrom
MukundaKatta:codex/sep1577-sampling-polish
Draft

fix: polish SEP-1577 sampling handling#765
MukundaKatta wants to merge 1 commit into
modelcontextprotocol:mainfrom
MukundaKatta:codex/sep1577-sampling-polish

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • reject empty sampling content in SamplingMessage and CreateMessageResult constructors
  • clarify sampling validation docs and emit an explicit error when tool_use is not followed by tool_result
  • return sampled text from the conformance test_sampling tool instead of content object strings

Fixes #730

Testing

  • ./gradlew -Dorg.gradle.java.installations.paths="/Users/ubl/Documents/New project/oss-contributions/.jdks/jdk-21.0.11+10/Contents/Home" :kotlin-sdk-core:jvmTest :kotlin-sdk-server:jvmTest :conformance-test:compileKotlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SEP-1577 sampling follow-up: invariants, validator messages, conformance

1 participant