Repository navigation
feat(web): display the installed EvalScope version - #1784
Merged
Merged
Conversation
Signed-off-by: git-jxj <65210887+git-jxj@users.noreply.github.com>
Reuse the design-system Badge (rounded-full, accent-dim bg) instead of a hand-rolled bordered box so the version chip matches the rest of the UI. Badge now forwards native span attributes so callers can set title.
Yunnglin
approved these changes
Sep 29, 2026
Yunnglin
left a comment
Yunnglin
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Verified end-to-end: backend returns the package version from evalscope.version via /api/v1/config; generated contracts match the generator output (schema regenerated byte-identical, contracts:check clean); the AppConfigProvider lift shares a single config fetch between ScanProvider and TopNav with correct provider nesting; Python contract tests (16) and web suite (470, incl. new MainLayout test) pass; ruff/eslint/tsc/drift clean; CI all green on the latest head. The version badge now reuses the design-system Badge pill (rounded-full, accent-dim), confirmed in a real browser. Non-blocking nit for follow-up: the tooltip string is hardcoded English rather than routed through t().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1/configendpoint.Closes #1778
Validation
python -m pytest tests/service/test_api_contracts.py -qnpm test(web: 470 tests)npm run contracts:checknpm run buildnpm run lintmake devmake lintmake lint-importspython -m pytest tests/cli/test_all.py::TestRun::test_ci_lite -v -s -p no:warnings