Repository navigation
docs: fix API key lookup in function calling examples - #1801
Merged
Merged
Conversation
Yunnglin
approved these changes
Oct 8, 2026
Yunnglin
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the fix — verified against the docs. The two Function Calling snippets referenced an undefined env, so copying them raised NameError before the run started. Your change to import os + os.getenv('DASHSCOPE_API_KEY') both resolves it and matches the convention already used by the other examples on the same pages. No env.get remains in either file, and CI is green. LGTM 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preset and local Function Calling examples in the English and Chinese custom-dataset guides use
env.get(...)without definingenv, so copying either example raisesNameErrorbefore evaluation starts.Import
osand readDASHSCOPE_API_KEYwithos.getenv, as the other examples on the same pages do.Validation: executed all four snippets using the real
TaskConfigwith evaluation mocked; each now builds the expected API configuration.make lintand the CI lite smoke test (mock model) pass.