Repository navigation
chore(perf): enforce F401 and remove unused imports - #1805
Open
loyce-cheng wants to merge 1 commit into
Open
loyce-cheng wants to merge 1 commit into
loyce-cheng wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue the directory-by-directory F401 rollout from #1689 and #1691 by enabling unused-import checks in
evalscope/perf. Remove the 27 newly reported unused imports in 20 files; keep the existing__init__.pyexemption and plugin registration imports intact.The three removed internal names come from modules that are still imported by the same statements, so their module initialization is preserved. No benchmark logic or evaluation semantics change. Other F401 scopes and UP/SIM remain outside this focused follow-up.
Refs #1631
Validation:
ruff check .andruff format --check .pass with the pinned Ruff 0.16.4..github/copilot-instructions.md); the repository hook configuration is unchanged.tests/cli/test_all.py::TestRun::test_ci_litepasses with the mock model.test_async_lifecycle.pyreproduce identically on the unchanged base: a Windows path used as a regex and the SIGINT subprocess exit code. The remotetest_multi_parallel_sweepskips without an API key.git diff --checkpasses.