Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark contribution guide says adapters are imported at startup and makes the only index-refreshing workflow optional. Since the lazy registry change, following the two-file example leaves
_index.jsonstale and fails the existing registry contract tests.Describe on-demand loading and add a required index-generation step, including the local contract check and the instruction to commit the generated index.
Validation: created the guide's sample adapter and reproduced two failing index checks;
make docs-update-indexresolved both and all 27 registry contract tests passed.make lintand the CI Lite smoke test passed. The sample adapter and its generated index entry were removed after validation.