Repository navigation
Avoid cross-document QSA scoring for packed inputs - #211
Merged
hjh0119 merged 1 commit intoOct 8, 2026
Merged
Conversation
Signed-off-by: Yuchen Wang <93700456+yuchenwang3@users.noreply.github.com>
yuchenwang3
marked this pull request as ready for review
October 3, 2026 20:42
hjh0119
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Packed QSA currently scores every query against every complete block in the pack, then masks blocks from other documents. For packs containing several documents, most of those scores are discarded.
This scores each document against its own complete blocks while retaining the existing query chunk budget, causal visibility, stable tie order, pack-space indices, and padded output width. It leaves key pooling, RoPE, and partial-block tails in the existing path. The document loop adds a host read of
cu_seqlens.The regression tests compare selected IDs with an independent globally masked reference, including empty documents, short documents, tails, ties, and different chunk sizes. A four-document test records 1,024 query/block pairs instead of 4,096. This is a work-count check, not a throughput measurement.
Validation:
pre-commit run --all-filespassed.Implementation and tests were generated with OpenAI Codex.