Repository navigation
Conversation
_eval_pattern allowed digits, brackets, and * and then called eval. That blocks names and attribute access. It still accepts [0]*10**9, which allocates the list inside eval. moe_layer_freq, linear_attention_freq, no_rope_freq, and window_attn_skip_freq all go through this function when the value contains a bracket. The same list grammar is now a small parser: lists of integers, concatenation with +, and repetition with *. A result longer than 100000 items is rejected, and ** is rejected. ([0]*3+[1]*1)*3 still expands to [0, 0, 0, 1] repeated three times. Checked with python3 -m pytest tests/test_layer_pattern.py.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_eval_patternallowed digits, brackets, and*and then calledeval. That blocks names and attribute access. It still accepts[0]*10**9, which allocates the list insideeval.moe_layer_freq,linear_attention_freq,no_rope_freq, andwindow_attn_skip_freqall go through this function when the value contains a bracket.The same list grammar is now a small parser: lists of integers, concatenation with
+, and repetition with*. A result longer than 100000 items is rejected, and**is rejected.([0]*3+[1]*1)*3still expands to[0, 0, 0, 1]repeated three times.Checked with
python3 -m pytest tests/test_layer_pattern.py.flake8is clean.