Repository navigation
Conversation
SafetensorLazyLoader joined the model directory with the filename from model.safetensors.index.json and opened the result. os.path.join drops the directory when the filename is absolute, and a relative name such as ../../other.safetensors resolves outside the directory. checkpoint_path realpaths both sides and requires the file to stay under the model directory. Absolute names are rejected before the join. The index file itself is still the fixed name model.safetensors.index.json. Checked with python3 -m pytest tests/test_checkpoint_path.py. A shard inside the directory resolves, and both ../outside.safetensors and an absolute path raise ValueError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SafetensorLazyLoaderjoined the model directory with the filename frommodel.safetensors.index.jsonand opened the result.os.path.joindrops the directory when the filename is absolute, and a relative name such as../../other.safetensorsresolves outside the directory.checkpoint_pathrealpaths both sides and requires the file to stay under the model directory. Absolute names are rejected before the join. The index file itself is still the fixed namemodel.safetensors.index.json.Checked with
python3 -m pytest tests/test_checkpoint_path.py. A shard inside the directory resolves, and both../outside.safetensorsand an absolute path raiseValueError.flake8is clean.