Repository navigation
Conversation
Loading linear_fc1 for local experts aborted when add_bias_linear and a block scale were both set. The weight path already reads gate_up_proj_scale_inv, and the bias path already copies gate_up_proj_bias with hf_scale_inv left empty. The assert was the only thing keeping the two apart. Export already writes the bias and the scale as separate tensors. The assert now only requires a local expert. A non-expert fc1 bias is still refused, because that layout is not converted here. flake8 is clean on gpt_bridge.py.
Collaborator
|
Which model actually encountered this issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading
linear_fc1for local experts aborted whenadd_bias_linearand a block scale were both set. The weight path already readsgate_up_proj_scale_inv, and the bias path already copiesgate_up_proj_biaswithhf_scale_invleft empty. The assert was the only thing keeping the two apart. Export already writes the bias and the scale as separate tensors.The assert now only requires a local expert. A non-expert fc1 bias is still refused, because that layout is not converted here.
flake8is clean ongpt_bridge.py.