chore: update @vitejs/plugin-react in examples and migrate to react compiler#761
Open
smeng9 wants to merge 2 commits into
Open
chore: update @vitejs/plugin-react in examples and migrate to react compiler#761smeng9 wants to merge 2 commits into
smeng9 wants to merge 2 commits into
Conversation
added 2 commits
May 29, 2026 10:59
commit: |
Contributor
Author
If I don't perform the following then the host app will crash with an exception |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gioboa
In latest version of React, it encourages the adoption of React Compiler https://react.dev/learn/react-compiler/introduction .
I have updated the example to support react compiler.
However I have one question regarding the shared dependency cache key, why is it different from the @module-federation/enhanced ones? This took almost an hour to figure out why the code is failing without the CACHE_KEY patch. For normal users they shouldn't need this setup for it to work.