Add lookahead to LWS import wallet spec#1228
Open
vtnerd wants to merge 1 commit intomonero-project:masterfrom
Open
Add lookahead to LWS import wallet spec#1228vtnerd wants to merge 1 commit intomonero-project:masterfrom
vtnerd wants to merge 1 commit intomonero-project:masterfrom
Conversation
90a320c to
ecf2bc3
Compare
ecf2bc3 to
aaee3a1
Compare
Contributor
Author
|
Force pushed the latest recommended spec for lookahead. This is the one in use my |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is one small issue with #647 - it's impossible to do a proper "lookahead" when doing an "import" or "recovery" scan. Basically, the client is forced to do constant
/import_wallet_requestcalls every time it observes a new subaddress in one of the/get...endpoints. This isn't really practical.Instead, a
lookaheadandheightfield is added to the/import_wallet_requestendpoint, and the server asynchronously returns failure if the subaddress max is reached in one of the/get...endpoints.