-
Notifications
You must be signed in to change notification settings - Fork 0
Fix Task Manager dark theme: pagination, status colors, action buttons #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
4
commits into
main
Choose a base branch
from
copilot/fix-pagination-white-dark-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ca2dcf3
Initial plan
Copilot f14971c
Fix task manager dark theme: pagination, status colors, button gradients
Copilot 57ba27a
adjust colors for dark mode
IslandRhythms 935ee43
Merge branch 'main' into copilot/fix-pagination-white-dark-mode
vkarpov15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,10 +60,49 @@ | |
| background-color: var(--studio-bg-success); | ||
| } | ||
|
|
||
| /* Status card/badge backgrounds (100-level) */ | ||
| .dark .bg-yellow-100 { | ||
| background-color: var(--studio-bg-warning); | ||
| } | ||
|
|
||
| .dark .bg-green-100 { | ||
| background-color: var(--studio-bg-success); | ||
| } | ||
|
|
||
| .dark .bg-red-100 { | ||
| background-color: var(--studio-bg-error); | ||
| } | ||
|
|
||
| .dark .bg-blue-100 { | ||
| background-color: var(--studio-bg-info); | ||
| } | ||
|
|
||
| /* Status pill active/selected backgrounds (200-level) */ | ||
| .dark .bg-yellow-200 { | ||
| background-color: var(--studio-bg-warning-active); | ||
| } | ||
|
|
||
| .dark .bg-green-200 { | ||
| background-color: var(--studio-bg-success-active); | ||
| } | ||
|
|
||
| .dark .bg-red-200 { | ||
| background-color: var(--studio-bg-error-active); | ||
| } | ||
|
|
||
| /* Status card/badge hover backgrounds */ | ||
| .dark .hover\:bg-yellow-100:hover { | ||
| background-color: var(--studio-bg-warning-hover); | ||
| } | ||
|
|
||
| .dark .hover\:bg-green-100:hover { | ||
| background-color: var(--studio-bg-success-hover); | ||
| } | ||
|
|
||
| .dark .hover\:bg-red-100:hover { | ||
| background-color: var(--studio-bg-error-hover); | ||
| } | ||
|
|
||
| .dark .border-red-200 { | ||
| border-color: var(--studio-border-error); | ||
| } | ||
|
|
@@ -76,6 +115,55 @@ | |
| border-color: var(--studio-border-success); | ||
| } | ||
|
|
||
| /* Hover/other status borders (200-level is handled above) */ | ||
| .dark .border-yellow-300 { | ||
| border-color: var(--studio-border-warning); | ||
| } | ||
|
|
||
| .dark .border-green-300 { | ||
| border-color: var(--studio-border-success); | ||
| } | ||
|
|
||
| .dark .border-red-300 { | ||
| border-color: var(--studio-border-error); | ||
| } | ||
|
|
||
| .dark .hover\:border-yellow-300:hover { | ||
| border-color: var(--studio-border-warning); | ||
| } | ||
|
|
||
| .dark .hover\:border-green-300:hover { | ||
| border-color: var(--studio-border-success); | ||
| } | ||
|
|
||
| .dark .hover\:border-red-300:hover { | ||
| border-color: var(--studio-border-error); | ||
| } | ||
|
|
||
| /* Status text colors – label (600-level) and value (700–900-level) */ | ||
| .dark .text-yellow-600, | ||
| .dark .text-yellow-700, | ||
| .dark .text-yellow-800, | ||
| .dark .text-yellow-900 { | ||
| color: var(--studio-text-warning); | ||
|
Comment on lines
+143
to
+148
|
||
| } | ||
|
|
||
| .dark .text-green-600, | ||
| .dark .text-green-800, | ||
| .dark .text-green-900 { | ||
| color: var(--studio-text-success); | ||
| } | ||
|
|
||
| .dark .text-red-600, | ||
| .dark .text-red-800, | ||
| .dark .text-red-900 { | ||
| color: var(--studio-text-error); | ||
| } | ||
|
|
||
| .dark .text-blue-800 { | ||
| color: var(--studio-text-info); | ||
| } | ||
|
|
||
| .dark .text-red-700 { | ||
| color: var(--studio-text-error); | ||
| } | ||
|
|
@@ -92,6 +180,28 @@ | |
| --tw-ring-color: var(--studio-ring-muted); | ||
| } | ||
|
|
||
| /* Status ring colors in dark mode */ | ||
| .dark .ring-yellow-400, | ||
| .dark .ring-yellow-500 { | ||
| --tw-ring-color: var(--studio-ring-warning); | ||
| } | ||
|
|
||
| .dark .ring-green-400, | ||
| .dark .ring-green-500 { | ||
| --tw-ring-color: var(--studio-ring-success); | ||
| } | ||
|
|
||
| .dark .ring-red-400, | ||
| .dark .ring-red-500 { | ||
| --tw-ring-color: var(--studio-ring-error); | ||
| } | ||
|
|
||
| .dark .ring-gray-400, | ||
| .dark .ring-gray-500, | ||
| .dark .ring-slate-500 { | ||
| --tw-ring-color: var(--studio-ring-muted); | ||
| } | ||
|
|
||
| /* ---- Ring / shadow ---- */ | ||
| .dark .ring-black\/5, | ||
| .dark .ring-opacity-5 { | ||
|
|
@@ -358,6 +468,62 @@ | |
| } | ||
|
|
||
|
|
||
| /* ---- Task action button gradients (dark mode) ---- */ | ||
| .dark .from-blue-500 { | ||
| --tw-gradient-from: #1d4ed8; | ||
| --tw-gradient-stops: var(--tw-gradient-from), var(--tw-gradient-to, rgb(29 78 216 / 0)); | ||
| } | ||
|
|
||
| .dark .to-blue-600 { | ||
| --tw-gradient-to: #1e40af; | ||
| } | ||
|
|
||
| .dark .hover\:from-blue-600:hover { | ||
| --tw-gradient-from: #2563eb; | ||
| --tw-gradient-stops: var(--tw-gradient-from), var(--tw-gradient-to, rgb(37 99 235 / 0)); | ||
| } | ||
|
|
||
| .dark .hover\:to-blue-700:hover { | ||
| --tw-gradient-to: #1d4ed8; | ||
| } | ||
|
|
||
| .dark .from-green-500 { | ||
| --tw-gradient-from: #15803d; | ||
| --tw-gradient-stops: var(--tw-gradient-from), var(--tw-gradient-to, rgb(21 128 61 / 0)); | ||
| } | ||
|
|
||
| .dark .to-green-600 { | ||
| --tw-gradient-to: #166534; | ||
| } | ||
|
|
||
| .dark .hover\:from-green-600:hover { | ||
| --tw-gradient-from: #16a34a; | ||
| --tw-gradient-stops: var(--tw-gradient-from), var(--tw-gradient-to, rgb(22 163 74 / 0)); | ||
| } | ||
|
|
||
| .dark .hover\:to-green-700:hover { | ||
| --tw-gradient-to: #15803d; | ||
| } | ||
|
|
||
| /* Red action buttons: pending cancel (dark mode) */ | ||
| .dark .from-red-500 { | ||
| --tw-gradient-from: #b91c1c; | ||
| --tw-gradient-stops: var(--tw-gradient-from), var(--tw-gradient-to, rgb(185 28 28 / 0)); | ||
| } | ||
|
|
||
| .dark .to-red-600 { | ||
| --tw-gradient-to: #991b1b; | ||
| } | ||
|
|
||
| .dark .hover\:from-red-600:hover { | ||
| --tw-gradient-from: #dc2626; | ||
| --tw-gradient-stops: var(--tw-gradient-from), var(--tw-gradient-to, rgb(220 38 38 / 0)); | ||
| } | ||
|
|
||
| .dark .hover\:to-red-700:hover { | ||
| --tw-gradient-to: #b91c1c; | ||
| } | ||
|
|
||
| /* ---- Input placeholder contrast ---- */ | ||
| .dark ::placeholder, | ||
| .dark .placeholder\:text-gray-400::placeholder { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dark-mode status background overrides cover yellow/green/red/blue, but Task Manager also uses
bg-gray-100for thecancelledstatus (seegetStatusColor()), which is not overridden here and will stay very light in dark mode. Consider adding a.dark .bg-gray-100override (and related gray status classes) so cancelled badges don’t glare against dark backgrounds.