Repository navigation
Unify ECS queries, typed system parameters, and deferred schedules - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Component access now requires a World or an opaque World-bound query, and ordinary systems declare their dependencies through typed parameters. Structural changes are queued through Commands and applied only when a complete ECS Schedule finishes. App execution and custom loops share this boundary; raw flushes and immediate entity mutation remain private.
Validation:
moon check --target all --deny-warn --warn-list +73: warning-free.moon test --deny-warn --warn-list +73: 437 Wasm and 83 JS tests passed.python3 -m unittest discover -s tests -p 'test_*.py': 30 passed. Independent consumers verify removed/private APIs, rejected internal imports and World injection, complete scheduling, deferred traversal, invalidated iterators, and isolated missing-resource/state failures.Recorded query benchmarks and reproduction commands remain in ECS benchmarks. Earlier measurements compare ordinary loops with scoped columns; they do not measure the subsequent system-parameter and gameplay migrations. Lazy rows still construct tuples and dispatch iterators. Browser FPS and WebGPU rendering were not measured.
This intentionally breaks the old component-access and system/execution APIs. Mutable component objects retain MoonBit reference semantics. Typed injection declares dependencies but does not add borrow checking or parallel scheduling; batch and schedule execution remain guarded at runtime.
CI uses only the latest MoonBit toolchain on Linux, macOS, and Windows. Remove the pre-release compatibility job and its contributor guidance. The workflow YAML parses successfully and diff checks pass.