Enhanced Pseudos:keys and new Pseudos:stop

[w00fz]

The Pseudos:keys now supports multiple key combinations element.addEvent('keydown:keys('shift+a, ,, delete, esc', myFun); and there's a new Pseudos:stop element.addEvent('click:stop', myFun);

[cpojer]

I like the extension to Keyboard, but I dislike the :stop pseudo. It's a good idea but we shouldn't encourage our users to use event.stop() when you really want event.preventDefault(). There are only few cases where you want to stop propagating. I'm in favor of adding click:preventDefault instead of click:stop. I might agree to adding all three, ie. click:stop, click:stopPropagation, click:preventDefault.

[arian]

Pretty sweet! Usually I just use event.stop() but that might not be best practice. Adding preventDefault and stopPropagation might solve that: http://jsfiddle.net/v2Wbs/

[cpojer]

Usually when you say event.stop() you really mean event.preventDefault()

[seanmonstar]

#234 anyone?

[w00fz]

I have reverted my multiple keys support on the Pseudo.Keys (should pull from @seanmonstar, I haven't seen it was there already, sorry about that) and Pseudos.Stop now has support for all 3 :stopPropagation, :preventDefault, :stop.
In the Docs they are in that order, with :stop as last, just for @cpojer .

[arian]

I approve

[cpojer]

@arian then merge it

[arian]

@cpojer: what do you think i'm doing?

On Fri, May 27, 2011 at 12:48 PM, cpojer
reply@reply.github.com
wrote:

@arian then merge it

Reply to this email directly or view it on GitHub:
#245 (comment)

[anutron]

blerg to merges.

[arian]

This should be pushed / merged / rebased / whatever together with #234. A week ago I did that, but @timwienk has some improved branch, so I reverted that again. However it should still be pushed.

[timwienk]

Specifically this branch.

[timwienk]

I just pulled w00fz' pseudos on top of my branch. I did another commit, which I think is a good idea.

I think that if we're going to add these pseudos, it's a good idea to make them a bit more flexible and check the first argument. If you guys don't agree, I can obviously push without that commit.

Specs seem to pass in Chrome.

[w00fz]

I'm totally fine with it. Although most of the times it's a true check it gives some more flexibility which is good and does cost nothing.

// Djamil Legato

On Jun 6, 2011, at 12:08 AM, timwienk reply@reply.github.com wrote:

I just pulled w00fz' pseudos on top of my branch. I did another commit, which I think is a good idea.

I think that if we're going to add these pseudos, I think it's a good idea to make them a bit more flexible and check the first argument. If you guys don't agree, I can obviously push without that commit.

Specs seem to pass in Chrome.

Reply to this email directly or view it on GitHub:
#245 (comment)

[arian]

@timwienk, @w00fz, @seanmonstar: what's the status of this? is it pushable?