smite: add closing_complete codec#105
Open
ekzyis wants to merge 1 commit into
Open
Conversation
ekzyis
force-pushed
the
closing-complete
branch
4 times, most recently
from
249aa32 to
06abdf2
Compare
ekzyis
commented
May 28, 2026
| // | ||
| // When closing a channel and shutdown is complete, each peer sends | ||
| // `closing_complete` with the transaction details. | ||
| #[derive(Debug, Clone, Default, PartialEq, Eq)] |
Contributor
Author
There was a problem hiding this comment.
I added the Default trait here, instead of a sample_closing_complete() function in the tests (bolt.rs + bolt/<message>.rs).
This is inconsistent with the other messages though.
I wonder if there was a reason to not use the Default trait, or if we should also use the Default trait for them. We could get rid of a lot of code in the tests. It does not look to me like the specific values picked for the sample messages matter.
Adding a Default trait just for less code in the tests might be a bad argument though.
ekzyis
commented
May 28, 2026
| } | ||
|
|
||
| #[test] | ||
| fn decode_truncated_closer_scriptpubkey_length_prefix() { |
Contributor
Author
There was a problem hiding this comment.
Testing truncated length prefixes is new. Not sure if needed.
ekzyis
force-pushed
the
closing-complete
branch
3 times, most recently
from
ae096c9 to
c0a4be7
Compare
This was referenced May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #98