smite-ir: implement ChannelUpdateGenerator#114
Draft
devvaansh wants to merge 2 commits into
Draft
Conversation
7013579 to
82d9aa6
Compare
82d9aa6 to
e1af2c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates programs that build and send correctly-signed
channel_updatemessages to the target.The signing key, chain hash, and short channel id are drawn via
pick_variableso they can be shared with other gossip messages (e.g. a precedingchannel_announcement) when generators are composed in the future.message_flagsandchannel_flagsare exposed as plainU8variables so that OperationParamMutator can flip individual bits, including must_be_one, direction, and disable.Note:
fee_base_msatandfee_proportional_millionthsare currently typed asAmountuntil theForwardingFeevariable type lands in #99.Depends on #110 (
BuildChannelUpdateoperation) and #99 (ForwardingFeevariable type).Ref: #71