Preserve failure diagnostics and classify unavailable capture prerequisites - #93
Merged
Conversation
morluto
marked this pull request as ready for review
August 2, 2026 04:08
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b145dee99d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #87–#92 as one failure-observability and environment-readiness change:
perfsampling as unusable, including the observedperf_event_paranoidrestriction and remediation;nvccworkloads and classifies missing development headers asenvironment_blocked;Root cause
The affected paths generally retained only a terminal error or binary-presence check. Managed staging replaced underlying network/filesystem/verification causes, operation progress never received the staging phase, capability probes treated
perf --versionas sufficient, and adapter/test evidence lacked a bounded way to distinguish wrapper or toolchain failures from workload defects. MCP initialization also did not pass its existing external workspace capability through the server boundary.Validation
uv run pytest -q— 299 passed, 112 deselecteduv run ruff check src testsuv run ruff format --check src testsuv run mypy src testsgit diff --checkThe deselected tests are optional/provider-specific integration lanes; synthetic regression tests cover the new failure paths, while a real Torch/GPU environment was not available for those optional lanes.
Closes #87
Closes #88
Closes #89
Closes #90
Closes #91
Closes #92