ci(benchmarks): upload timing evidence via non-hidden filename - #345
Merged
Merged
Conversation
The Publish Benchmark Timings job writes `.benchmark-timings.json` (a dotfile) and uploads it with `actions/upload-artifact`. Since v4.4.0 that action excludes hidden files by default, and the pinned action logs `include-hidden-files: false` regardless of the input, so with `if-no-files-found: error` the upload failed with "No files were found with the provided path: .benchmark-timings.json" on every benchmark PR run that reached the timings job (e.g. PR #331 run 30749872475, PR #321 run 30750885213). Keep `.benchmark-timings.json` as the collector output so the planner cache-restore and the main-branch cache-save (which use actions/cache, unaffected by the hidden-file exclusion) keep working unchanged. Add a minimal `cp` step after collection that stages a non-hidden `benchmark-timings.json`, and point only the Upload timing evidence step at that non-hidden file. No benchmark verifier or collector code changes. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
morluto
marked this pull request as ready for review
August 2, 2026 14:16
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the shared benchmark timing-upload failure that affects multiple benchmark pull requests.
Problem
The
Publish Benchmark Timingsjob collects its output as.benchmark-timings.json. The pinnedactions/upload-artifactaction excludes hidden files, so the upload step fails with:The same failure was reproduced on benchmark PRs including #331 and #321.
Change
Keep
.benchmark-timings.jsonunchanged for planner and cache behavior. Stage a non-hiddenbenchmark-timings.jsonimmediately after collection and upload that file instead. No benchmark collector or verifier behavior changes.Validation
uv run pre-commit run --files .github/workflows/benchmarks.yml— all hooks passed, including actionlint.git diff --check origin/main..origin/codex/fix-benchmark-timing-upload-20260802— clean.The PR is intentionally limited to the shared workflow fix.