[Exit bundles] margin test - #44
Conversation
Address review feedback by keeping each explanatory sentence on its own comment line.
QGarchery
changed the title
QGarchery
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0d1efba62d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| function testMarginV2Liquid(uint256 numberOfMarkets) public { | ||
| numberOfMarkets = bound(numberOfMarkets, 1, MAX_NUMBER_OF_MARKETS); | ||
| _setupV2(numberOfMarkets, false); |
There was a problem hiding this comment.
In this setup every deposited asset is allocated and no liquidity adapter is configured, so withdrawableAssets in VaultExitBundlesV1.sol:173-186 is zero and the claimed upfront withdrawal is always withdraw(0). Consequently this case never exercises the additional rounding operation used to justify the numberOfMarkets + 2 margin; leave some idle assets or configure a liquidity adapter, and assert that the upfront amount is nonzero before checking this bound.
AGENTS.md reference: AGENTS.md:L77-L77
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
@prd-carapulse[bot] fix this, in this PR: add a liquidity adapter
There was a problem hiding this comment.
⏳ Working — 9 min — iteration 21/200, terminal
1 participant
No description provided.