[vaultExit] document lack of slippage check in IKR and add shareprice slippage check force withdraw#71
Merged
Merged
Conversation
bhargavbh
marked this pull request as draft
July 20, 2026 08:01
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ad911885ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
bhargavbh
marked this pull request as ready for review
July 22, 2026 07:16
bhargavbh
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2400584c24
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
QGarchery
changed the title
QGarchery
changed the title
bhargavbh
commented
Jul 24, 2026
QGarchery
reviewed
Jul 24, 2026
QGarchery
approved these changes
Jul 24, 2026
QGarchery
requested changes
Jul 24, 2026
# Conflicts: # src/vault-exit/VaultExitBundlesV1.sol # src/vault-exit/interfaces/IVaultExitBundlesV1.sol
QGarchery
approved these changes
Jul 24, 2026
MathisGD
reviewed
Jul 24, 2026
Comment on lines
+226
to
+227
| uint256 sharesBurned = sharesBefore - IERC20(vault).balanceOf(msg.sender); | ||
| require(sharesBurned == 0 || withdrawn.mulDivDown(1e27, sharesBurned) >= minSharePriceE27, SlippageExceeded()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://cantina.xyz/code/ded8848a-c712-49cb-a148-eca694667074/findings/13
https://cantina.xyz/code/ded8848a-c712-49cb-a148-eca694667074/findings/7
https://cantina.xyz/code/ded8848a-c712-49cb-a148-eca694667074/findings/9
https://cantina.xyz/code/ded8848a-c712-49cb-a148-eca694667074/findings/10