chore(repo): remove remaining deprecated packages - #811
Conversation
Rubilmax
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce2e01c401
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Pull request was converted to draft
ee42735 to
2626f5b
Compare
Rubilmax
changed the title
59c8772 to
c5076d5
Compare
2626f5b to
8cd4a0f
Compare
8cd4a0f to
84a9255
Compare
Resolves the conflicts by taking `main` as the base for every file and re-applying only the deprecated-package removal on top, so nothing landed on `main` since the branch point is reverted. The branch had been rebased in a way that dropped work merged into `main` after its branch point. Restored from `main` and kept out of the resolution: - `ReallocationData.getPublicReallocationLiquidity` and `getAvailableLiquidityToUtilization` (#796, #813) plus their `reallocationData.metrics.test.ts` suite. - `helpers/utilization.ts` (`getSupplyTargetUtilization`) and its use in `computeReallocations`, including the #866 target-utilization changes. - `morpho-sdk` version 5.4.1 and its 4.1.0 → 5.4.1 CHANGELOG entries (the branch reset the manifest to 4.0.0). - `docs/tibs/TIB-2026-06-16-shared-liquidity-target-utilization-metric.md`. - The `README.md` "Secondary packages" wording and the `midnight-sdk` entry. - `BundlerAction.morphoSetAuthorizationWithSig` and the `midnight-sdk` Vitest project / fork-test timeouts. Deprecated-package removal re-applied against current `main`: - Deleted `simulation-sdk`, `bundler-sdk-viem`, `blue-sdk-wagmi`, `migration-sdk-viem`, `simulation-sdk-wagmi`. - Dropped their Biome ignores, Typedoc entry points, Vitest projects and CI filters, JSDoc coverage tiers, and the `--exclude-deprecated` checksum-lint flag. - Removed the frozen-deprecated-package rules from `AGENTS.md` and the `code-quality` / `style-conventions` / `ci-release-security` personas. - Dropped the two `morpho-sdk` devDependencies on the deleted packages and the parity suites that were their only consumers (`bundler-sdk-viem parity` in `bundler/actions.test.ts`, `ReallocationData SimulationState parity` in `reallocationData.test.ts`). - Regenerated `pnpm-lock.yaml` (deletions only, no version drift). Validation: `pnpm lint`, `pnpm build:ci`, `tsc --noEmit` per package, and 1395 + 510 + 96 non-fork tests pass. Fork suites need RPC secrets and were not run locally.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d6854c94a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review: the deprecated packages stay published on npm (TIB-0003 Phase 3 forbids unpublishing historical versions), so morpho-sdk 3.0.0 really did resolve @morpho-org/simulation-sdk@4.0.0 and @morpho-org/bundler-sdk-viem@5.0.0. Deleting those "Updated dependencies" bullets and rewriting the release prose made the changelogs describe a dependency graph that never shipped, and misleads anyone diagnosing an older install. CHANGELOG.md is also a Changesets-generated output, which AGENTS.md §8 says not to hand-edit. Reverts the changelog edits in morpho-sdk and liquidity-sdk-viem; package name cleanup stays limited to current documentation and configuration. This matches #817, which deleted the removed packages' own changelogs but left surviving packages' history untouched.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e23bda4a0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
Rebased on
origin/mainafter #817 landed.Removes the remaining deprecated packages reserved for later archive:
simulation-sdk,bundler-sdk-viem,blue-sdk-wagmi,migration-sdk-viem, andsimulation-sdk-wagmi.Cleans the remaining docs, tooling, lockfile, and morpho-sdk parity references that existed only for those packages.
Validation:
pnpm lint.