Repository navigation
fix(deps): security batch — ws - #85
Merged
haydenshively merged 2 commits intoOct 1, 2026
Merged
haydenshively merged 2 commits into
haydenshively merged 2 commits into
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
haydenshively
added this pull request to stack #86
October 1, 2026 19:25
haydenshively
approved these changes
Oct 1, 2026
Collaborator
|
Devin can you make sure your commits are signed across this stack? |
…2026-10-01 (APPS-1649)
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
deps/batch/security-2026-10-01-2
branch
from
October 1, 2026 20:00
e2eb55e to
69294bf
Compare
Contributor
Author
|
@haydenshively Done. Two commits in the stack were signed with a key GitHub didn't recognise ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by fix-vulnerable-deps
Stacked on #84
Fixes: ws — AIKIDO-2026-138234 (HIGH)
Linear: APPS-1649
Summary
ws8.21.0 → 8.21.1 in bothpnpm-lock.yamlandplayground/pnpm-lock.yaml, via a new overridews: 8.21.1in bothpnpm-workspace.yamlfiles (the playground duplicates the root's settings).wsto exactly 8.21.0 (throughviemandisows), so moving the parent doesn't help. 8.21.1 is the lowest fixed version on the 8.x line (released 2026-07-14, past the 7-day gate). Remove the override once viem ships a fixedws.viem(dev/peer dependency) for tests and the playground build; nothing here reaches the publisheddist.vet: pass (integrity, release age ≥ 7 days, no install scripts, same publisher and repo; upstream diff is the fragment-count fix in
lib/receiver.jsplus lower defaultmaxFragments/maxBufferedChunks).Checks run locally:
pnpm install,pnpm exec biome check .,pnpm typecheck,pnpm -C playground install --frozen-lockfile,pnpm -C playground typecheck,pnpm -C playground build,pnpm test(Node 24: 685 passed, 1 skipped). Fix check: nows< 8.21.1 resolves in either lockfile (OSV has no record of this Aikido advisory); OSV rescan of both lockfiles finds only undici 6.28.0 (tracked in APPS-1644).Details
pnpm test:forgeand gas snapshot (forge couldn't download solc in the worker sandbox); no JS dependency involved, CI runs them.ws8.21.0 → 8.21.1 and theisows/viemsnapshot references to it;isows's peerwsentry becomes8.21.1. No packages added or removed.wsbelow 8.21.1 was treated as affected.Link to Devin session: https://app.devin.ai/sessions/55aa92b588e74674b9f2a00333d2813f
Open in Devin Desktop: https://app.devin.ai/desktop/session/55aa92b588e74674b9f2a00333d2813f?variant=devin