Preserve Clauditor GCP identity and clear Azure storage plan drift - #334
Merged
Merged
Conversation
jwmossmoz
marked this pull request as ready for review
September 14, 2026 14:09
jwmossmoz
enabled auto-merge (squash)
September 14, 2026 14:09
jwmossmoz
disabled auto-merge
September 14, 2026 14:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #333 changed the Clauditor Terraform key from
audiencetogcp-aud. Without state moves, Terraform deleted the original application and service principal, then failed to create a replacement with the original application ID URI.Add
movedblocks for the application, service principal, and Contributor role assignment. These preserve the original GCP client ID, audience URI, and role assignment when the key changes. Also correct the GCP application name in the comment.The
hardwareimagingstorage account also showed the same network rules change after each apply. Remove its redundant default network rules block. AzureRM 4.60.0 omits these defaults from state, which caused the repeated difference. The account continues to useAllowwith theAzureServicesbypass.Validation:
gcp-audaddresses in the shared state.azure_ad,azure_fuzzing, andazure_fxciall reported no changes with-detailed-exitcodeexit code 0.