RELOPS-2402: Pin the production hardware pools to ronin f328b45d (fleetbench) - #961
Merged
Merged
Conversation
Picks up ronin_puppet#1401 (fleetbench PSU/firmware-throttle detector), merged to master as f328b45d. Production's previous pin, 47042c6b, is its ancestor, so fleetbench plus the dependabot grouping in #1402 are the only new content. Image is unchanged: win11-24h2-hw-20260908-172915. Validated on both alpha pools first (worker-images#958, 5 nodes, all puppet exit 2 / bootstrap complete): the v0.4.6 collector downloaded and its on-disk SHA256 matches the pinned hash, the benchmark ran and wrote a result envelope, and both NSClient checks plus their nsclient.ini entries are in place. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up mozilla-platform-ops/ronin_puppet#1401 (fleetbench PSU/firmware-throttle detector), merged to master as
f328b45d.win11-64-24h2-hwwin11-24h2-hw-20260908-172915)47042c6b→f328b45dwin11-64-24h2-hw-ref47042c6b→f328b45dProduction's previous pin is an ancestor of
f328b45d, so the only new content is fleetbench plus the dependabot grouping from #1402. No role edits were needed — fleetbench is wired intoroles_profiles::profiles::hardware_observability, which every Windows hw role already includes (andwin116424h2hwbakedeliberately excludes, so nothing runs in the bake guest).Validated on alpha first
worker-images#958 staged this on
win11-64-24h2-hw-alpha(3 NUC13) andwin11-64-24h2-hw-ref-alpha(2 NUC12). All five:bootstrap_stage=complete, puppet exit 2, worker-runner Running.The collector downloaded, verified against the pinned checksum, and the benchmark actually ran and wrote an envelope — so this is not just "the files are present".
Two operational effects to expect fleet-wide
Invoke-FleetbenchCheckruns the collector to completion before worker-runner, for900s(15 min), once after bootstrap and then at most once perIntervalHours = 72. So each re-imaged node takes ~15 extra minutes before it claims its first task. Across a rolling 151-node re-image that is real, though it is a one-off per node and does not repeat until the 72h gate reopens on a later boot.Remove-Itemin the module clears the stderr file. At one envelope per 72h that is roughly 250 MB/node/month. Not urgent, and pruning needs care because the oldest envelope is the node's reference baseline for drop-off detection — so a naive "delete old files" would break the check. Worth a follow-up that keeps the oldest plus the most recent N.Follow-up, not in this PR
The two alpha pools still pin the
relops-2402-fleetbenchbranch @c353d2b6. Now that #1401 is merged they should move tomaster@f328b45dso they do not depend on a feature branch that can be deleted — that is a separate bump and another 5-node re-image.🤖 Generated with Claude Code