Repository navigation
fix(CI): Checkout the main branch in the main-generate-sql-and-dags GHA job - #8909
Merged
Merged
Conversation
scholtzan
approved these changes
Feb 25, 2026
…nd-dags` GHA job.
Contributor
Integration report for "fix(CI): Checkout the branch in the GHA job"
|
sean-rose
commented
Feb 25, 2026
| GENERATED_SQL_CHANGED=true | ||
| fi | ||
|
|
||
| git checkout main |
Contributor
Author
There was a problem hiding this comment.
@scholtzan the CircleCI version of the main-generate-sql-and-dags job wasn't switching back to main before rerunning the SQL generation, but I think this will result in a more accurate diff of what would be changed if the PR was merged into main. What do you think?
Contributor
There was a problem hiding this comment.
Yeah, this makes sense. I wonder if we didn't do it in CircleCI to reduce diff noise and ignore changes due to the branch being out-of-date, though I don't fully remember. This is at least something we should try and see.
Contributor
Integration report for "fix(CI): Checkout the branch in the GHA job"
|
sean-rose
enabled auto-merge
February 25, 2026 21:12
Contributor
Integration report for "fix(CI): Checkout the branch in the GHA job"
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Like the equivalent CircleCI logic did.
Related Tickets & Documents
Reviewer, please follow this checklist