Skip to content

feat(DENG-11530): mark suggest_revenue_levers_daily_v1, sponsored_tiles_clients_daily_v1, and adm_forecasting_v1 as deprecated - #9815

Open
kik-kik wants to merge 1 commit into
mainfrom
feat/DENG-11530/deprecate-unified_metrics-unused-contextual_service-downstream-dependencies
Open

kik-kik wants to merge 1 commit into
mainfrom
feat/DENG-11530/deprecate-unified_metrics-unused-contextual_service-downstream-dependencies

Conversation

@kik-kik

@kik-kik kik-kik commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

feat(DENG-11530): mark suggest_revenue_levers_daily_v1, sponsored_tiles_clients_daily_v1, and adm_forecasting_v1 as deprecated

Those are downstream of unified_metrics_v1 and appear to be no longer be in use (based on lineage and conversations).

relates to: #9468 (PR to mark unified_metrics as deprecated)

Once this is merged and we confirm we can proceed forward a follow-up PR will be opened to remove scheduling from those queries.

@kik-kik kik-kik self-assigned this Aug 24, 2026
@kik-kik
kik-kik requested a review from a team as a code owner August 24, 2026 12:43

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds deprecated: true and deletion_date: 2026-08-24 to the metadata for contextual_services_derived.adm_forecasting_v1, contextual_services_derived.suggest_revenue_levers_daily_v1, and telemetry_derived.sponsored_tiles_clients_daily_v1, all downstream of unified_metrics_v1.

The main thing to settle is the deletion date, which is the same day the PR was opened rather than a future date, plus the follow-through items: the two contextual_services_derived tables are still scheduled daily in bqetl_ctxsvc_derived, and the three user-facing views on top of these tables are unchanged. Details inline.

One checklist note: suggest_revenue_levers_daily_v1 is change_controlled and owned by @mozilla/revenue_forecasting_data_reviewers in CODEOWNERS, so that team's approval is needed here.

@scholtzan

This comment has been minimized.

@jaredsnyder jaredsnyder left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

…aily_v1, and adm_forecasting_v1 as deprecated
@kik-kik
kik-kik force-pushed the feat/DENG-11530/deprecate-unified_metrics-unused-contextual_service-downstream-dependencies branch from 342d44e to 6e2259e Compare August 24, 2026 15:19
@scholtzan

Copy link
Copy Markdown
Contributor

Integration report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants