Improvements to CI check flagging sensitive data flows - #9893
Conversation
There was a problem hiding this comment.
This changes the Flag sensitive data flows step in .github/workflows/build.yml so it no longer propagates the sensitivity CLI's exit code, moves the any_changed check from a step-level if into the script, paginates the marker-comment lookup, writes findings to $GITHUB_STEP_SUMMARY, adds a retraction path that deletes the advisory comment and withdraws the dataplatform-wg review request when a push clears the flow, and adds an explanation of unresolved sources to the comment body.
Comments are workflow-only, so nothing here touches SQL conventions or schemas from the reviewer checklist. My findings center on the new retraction path: how it interacts with CODEOWNERS-driven review requests, and the job-level gate that prevents it from running in the revert case it's meant to handle. Verified against CODEOWNERS, the decide-runs job's validate-sql computation, and bigquery_etl/data_governance/cli.py (SENSITIVITY_UNGATED_EXIT_CODE = 2).
This comment has been minimized.
This comment has been minimized.
Integration report
|
Description
Fixes the "Flag sensitive data flows" check failing the build when it had nothing to report . The step now always exits 0.
Also retracts stale advisories: when a push clears the flow, the check deletes its earlier comment and withdraws its own
dataplatform-wgreview request.Related Tickets & Documents
Reviewer, please follow this checklist