fix(nimbus): Approve only our own Kinto review in the selenium teardown - #16981
Open
jaredlockhart wants to merge 2 commits into
Open
fix(nimbus): Approve only our own Kinto review in the selenium teardown#16981jaredlockhart wants to merge 2 commits into
jaredlockhart wants to merge 2 commits into
Conversation
jaredlockhart
marked this pull request as ready for review
August 25, 2026 17:11
jaredlockhart
requested review from
RJAK11,
freshstrangemusic,
mikewilli and
yashikakhurana
as code owners
August 25, 2026 17:11
jaredlockhart
marked this pull request as draft
August 25, 2026 19:52
Collaborator
Author
|
Still trying to track down these intermittent Kinto approve CI failures, iterating in this PR with some extra logging. |
Because * The selenium teardown called approve() on the kinto_client factory, so it raised AttributeError and was swallowed by the bare except. * end_experiment() still ran, leaving a pending review that a later test signs as if it were its own, cascading until a test finds nothing pending and raises "Unable to approve kinto review". * approve() retries for 120s, so activating the teardown unbounded would burn that budget per test whenever no review is pending. This commit * Calls the factory so the teardown approves via a KintoClient instance. * Adds an optional retries argument to approve(), leaving the default budget unchanged for in-test callers. * Bounds the teardown to a short explicit budget. Fixes #16978
jaredlockhart
marked this pull request as ready for review
September 4, 2026 19:30
jaredlockhart
enabled auto-merge
September 9, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #16978