perf(nimbus): compute rollout review errors once per render - #17152
Draft
jaredlockhart wants to merge 1 commit into
Draft
perf(nimbus): compute rollout review errors once per render#17152jaredlockhart wants to merge 1 commit into
jaredlockhart wants to merge 1 commit into
Conversation
jaredlockhart
force-pushed
the
17151
branch
2 times, most recently
from
September 4, 2026 19:31
cb907f1 to
d78937a
Compare
jaredlockhart
changed the title
Because * Rendering a rollout page runs eleven full rollout review validation passes. * The sidebar reads the review error state ten times and the setup progress computes it again. This commit * Computes the rollout review errors once in the shared setup-progress context and has the sidebar read that, rather than each template reference recomputing them. * Adds the setup-progress context to the archive toggle view, which also renders the sidebar. Fixes #17151
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This commit
Fixes #17151