fix(nimbus): Always show the rollout preview link and toast on copy - #17257
Open
yashikakhurana wants to merge 2 commits into
Open
fix(nimbus): Always show the rollout preview link and toast on copy#17257yashikakhurana wants to merge 2 commits into
yashikakhurana wants to merge 2 commits into
Conversation
yashikakhurana
requested review from
RJAK11,
freshstrangemusic,
jaredlockhart and
mikewilli
as code owners
September 10, 2026 20:33
Contributor
Author
|
yashikakhurana
force-pushed
the
17051
branch
from
September 10, 2026 20:38
4bca531 to
a5c7a59
Compare
Show the about:studies URL itself, plus a copy button, directly under the note at the top of the "Preview links & testing details" card. It used to be a bare button at the bottom of the "Rollout experience" tile, below the screenshot, and the URL was never visible. The inner is_desktop guard was redundant since the card only renders for desktop rollouts in preview. Replace the inline onclick that relabelled the button to "Copied" with the existing toast machinery: both the URL and the button carry data-copy-text and data-toast-id, and rollout_cards.js gained a generic [data-copy-text] copy handler.
yashikakhurana
force-pushed
the
17051
branch
from
September 10, 2026 20:41
a5c7a59 to
f185080
Compare
yashikakhurana
enabled auto-merge
September 10, 2026 20:45
RJAK11
reviewed
Sep 10, 2026
RJAK11
left a comment
RJAK11
left a comment
Contributor
There was a problem hiding this comment.
Tested this locally and everything works perfectly! Just one minor thing: when I tested it with the devtools integrations, the force enroll section was the full width of the card. Do you think we should make that smaller?
Moving the pane out of the "Rollout experience" tile made it a direct child of the full-width column, so the Force Enroll box spanned the whole card. Put it in a col-md-6 so it lines up with the tile below it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
The preview link was buried at the bottom of the card, below the screenshot.
Clicking it relabeled the button to "Copied" instead of using a toast.
This commit
Shows the
about:studiesURL and a copy button directly under the note.Swaps the "Copied" relabel for the
TOAST_PREVIEW_LINK_COPIEDtoast.Screenshot
Fixes #17051