Skip to content

fix(nimbus): Move application out of overview and into the page header #17260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RJAK11 merged 1 commit into from
Sep 11, 2026
Merged

fix(nimbus): Move application out of overview and into the page header #17260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion experimenter/experimenter/nimbus_ui/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,10 @@ class NimbusUIConstants:
"Resolve the highlighted errors above before saving this plan."
)
ERROR_ROLLOUT_PHASE_LOCKED = "This rollout phase is locked and cannot be changed."
ROLLOUT_APPLICATION_TOOLTIP = (
"Rollouts can only target one Application at a time. Application can "
"not be changed after a rollout is created."
)
ROLLOUT_REVIEW_PENDING_TOOLTIP = "A review is currently pending."
ROLLOUT_NO_NEXT_PHASE_TOOLTIP = "There is no further phase to start."
ROLLOUT_HAS_ISSUES_TOOLTIP = "All rollout issues must be resolved first."
Expand Down Expand Up @@ -457,7 +461,6 @@ class NimbusUIConstants:
("Name", ("name",)),
("Observations & Problem Space", ("hypothesis",)),
("Public Description", ("public_description",)),
("Application", ("application",)),
("Important Links", ("documentation_links",)),
("Project Tags", ()),
("Subscribers", ()),
Expand Down
7 changes: 7 additions & 0 deletions experimenter/experimenter/nimbus_ui/templates/new/common/base.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,13 @@ <h1 id="experiment-header-name" class="mb-0 fw-semibold fs-4 text-body">{{ exper
<span>{{ experiment.slug }}</span>
<i class="fa-regular fa-copy"></i>
</button>
<div class="d-flex align-items-center gap-1 small text-secondary">
<span id="experiment-application">{{ experiment.get_application_display }}</span>
<i class="fa-regular fa-circle-question"
data-bs-toggle="tooltip"
data-bs-placement="right"
title="{{ NimbusUIConstants.ROLLOUT_APPLICATION_TOOLTIP }}"></i>
</div>
{% if experiment.parent %}
<p class="text-secondary small mb-0">
Cloned from
Expand Down
7 changes: 0 additions & 7 deletions experimenter/experimenter/nimbus_ui/templates/new/rollouts/overview/card.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,6 @@
style="white-space: pre-wrap">{{ experiment.public_description|default:"—" }}</div>
{% include "new/common/validation_errors.html" with errors=validation_errors.public_description %}

</div>
{# Application #}
<div>
<div class="text-secondary mb-1" style="font-size: 12px;">Application</div>
<div class="small text-body">{{ experiment.get_application_display }}</div>
{% include "new/common/validation_errors.html" with errors=validation_errors.application %}

</div>
{# Important Links #}
<div>
Expand Down
15 changes: 0 additions & 15 deletions experimenter/experimenter/nimbus_ui/templates/new/rollouts/overview/edit_form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,21 +40,6 @@

<p class="form-text mb-0">{{ NimbusUIConstants.PUBLIC_DESCRIPTION_TEXT }}</p>
</div>
{# Application #}
<div>
<label for="id_application" class="small text-body mb-1">Application</label>
{{ form.application }}
{% if form.application.errors %}
<div class="text-danger small mt-1">{{ form.application.errors|join:", " }}</div>
{% endif %}
{% include "new/common/validation_errors.html" with errors=validation_errors.application %}

<p class="form-text mb-0">
Rollouts can only target one Application at a time.
<br>
Application can not be changed after a rollout is created.
</p>
</div>
{# Important Links #}
<div>
<label class="small text-body mb-1">Important Links</label>
Expand Down
Loading