Skip to content

fix(nimbus): Show larger rollout screenshots in preview #17268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RJAK11 wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Open

fix(nimbus): Show larger rollout screenshots in preview #17268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions experimenter/experimenter/nimbus_ui/templates/new/rollouts/preview/card.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
tabindex="-1"
aria-labelledby="rollout-preview-screenshot-modal-label"
aria-hidden="true">
<div class="modal-dialog modal-md modal-dialog-centered">
<div class="modal-dialog modal-xl modal-dialog-centered modal-dialog-scrollable">
<div class="modal-content">
<div class="modal-header">
<h1 class="modal-title fs-5" id="rollout-preview-screenshot-modal-label">Rollout experience</h1>
Expand All @@ -64,14 +64,14 @@ <h1 class="modal-title fs-5" id="rollout-preview-screenshot-modal-label">Rollout
data-bs-dismiss="modal"
aria-label="Close"></button>
</div>
<div class="modal-body d-flex flex-column gap-3">
<div class="modal-body d-flex flex-column gap-4">
{% for screenshot in experiment.reference_branch.screenshots.all %}
{% if screenshot.image %}
<div>
<div class="text-center border border-secondary-subtle rounded p-3">
<img src="{{ screenshot.image.url }}"
alt="{{ screenshot.description|default:'Rollout experience screenshot' }}"
class="img-fluid w-100" />
{% if screenshot.description %}<div class="mt-2 small text-body">{{ screenshot.description }}</div>{% endif %}
class="img-fluid" />
{% if screenshot.description %}<div class="mt-2 text-body">{{ screenshot.description }}</div>{% endif %}
</div>
{% endif %}
{% endfor %}
Expand Down
Loading