Repository navigation
feat(nimbus): Add advanced targeting for newtab widgets available off by default - #17417
Conversation
|
(Intentionally leaving this as a draft right now) |
|
Note: I'm updating this to point towards the previous train-hop as requiring Fx158 is unnecessary and omitted the Stocks widget as part of the targeting. That will remain off and is not part of this query. |
6f6e21c to
872908f
Compare
|
I removed the train-hop dependency, and removed the Stocks widget. |
872908f to
303e55a
Compare
|
@maxxcrawford Please update your PR description to remove the striked-out text if it is no longer true. |
RJAK11
left a comment
RJAK11
left a comment
There was a problem hiding this comment.
Would it be possible to reformat this targeting expression a little just to make it easier to read through? Maybe using # fmt: off / # fmt: on around the targeting=() block and disabling the line length check there if needed
Also, just wanted to check whether these widget prefs are expected to support population sizing. It looks like the pref values/IsUserSet state needed by this targeting aren’t available in the Desktop targeting context for sizing. If sizing isn’t needed here, then I think this should be fine :)
303e55a to
cc3f182
Compare
|
@RJAK11 Updated to make the These widget prefs are not expected to support population sizing. |
cc3f182 to
e1ba6f0
Compare
… by default This commit adds targeting that excludes profiles which have explicitly enabled the New Tab widgets container or any individual widget, revealing a widget toggle also makes the widget addable, so a pre-existing user-set enabled: true would render it on the new tab page. Fixes mozilla#17416
e1ba6f0 to
0b1c423
Compare
RJAK11
left a comment
RJAK11
left a comment
There was a problem hiding this comment.
Thank you, it looks good to me now!
3 participants
This commit adds targeting that excludes profiles which have explicitly enabled the New Tab widgets container or any individual widget, revealing a widget toggle also makes the widget addable, so a pre-existing user-set enabled: true would render it on the new tab page.
Fixes #17416