[1.21.1] Add config options for liquid blaze burner, fix burn times for biofuel and blaze cakes#1160
Merged
Conversation
Add max heat capacity and max liquid capacity settings to the config file.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add max heat capacity and max liquid capacity settings to the config file for 1.21.1. Changed blaze cake burn time from 1000 to 3200 ticks, biofuel burn time from 2400 to 24000 to be more in line with recent create mod blaze cake burn times
Pull Request Checklist
Please review and complete all items before submitting your pull request:
MIT License Confirmation
Description
Added to config file:
This would enable players to configure the liquid blaze burners so that they would turn off when the liquid fuel supply is stopped (within as low as 12-24 seconds for special/superheated fuel and within 1m40s-3m20s for normal fuel when set to 0t and 100mB). It would also avoid a large fuel consumption spike when fuel is first supplied to the burners and they are initially empty and not burning.
EDIT: It seems the biofuel burn duration is currently bugged (See #1094 or commit 3a4b31e), the blaze burner should turn off in the fixed situation after 2 to 4 minutes for biofuel. Blaze cake duration was also outdated (#959).
Tested in Singleplayer and Multiplayer switching config from small to large capacities (no issues), large to small capacities (temporary internal storage larger than capacity, but no other issues), combinations of small heat capacity, small liquid capacity, etc.
This would be nice to be configurable in-game (like from the bottom of the blaze burner through one or two ValueBoxTransforms) and have the config values be a maximum, but that is a design decision which I leave up to you. I can look into implementing it if you want though.
Related Issues
Closes issues #1159, #959, and #1094 for branch 1.21.1