Skip to content

upgrade tmp to not use node internals#23

Open
hcldan wants to merge 1 commit intomrkmg:masterfrom
hcldan:master
Open

upgrade tmp to not use node internals#23
hcldan wants to merge 1 commit intomrkmg:masterfrom
hcldan:master

Conversation

@hcldan
Copy link

@hcldan hcldan commented Jan 11, 2021

No description provided.

@hcldan
Copy link
Author

hcldan commented Jan 11, 2021

upgrade tmp beyond #21
The travis build there may have been failing because tmp > 0.0.33 no longer supports older node versions.
So you would want to stop testing on Node 4 and Node 5

@roggervalf
Copy link

is there any chance to get this pr merged @mrkmg?

@SBoudrias
Copy link

SBoudrias commented Aug 9, 2025

This package not being maintained anymore, and being a core dependency of Inquirer, I went ahead and forked it over at https://www.npmjs.com/package/@inquirer/external-editor - I've maintained Inquirer for >12 years and its one of the most popular package on npm; so I think that project is trustworthy new owner.

It drops tmp in favor of node built-in, the interface for the v1 release is backward compatible to ensure an easy drop-in replacement for folks running into the CVE issue. (v2 onward could contain breaking changes as I modernize the codebase and simplify the interface)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants