fix(android): initialize CameraDevicesManager after React instance se…#3597
Open
MdAbubakar wants to merge 7 commits intomrousavy:mainfrom
Open
fix(android): initialize CameraDevicesManager after React instance se…#3597MdAbubakar wants to merge 7 commits intomrousavy:mainfrom
MdAbubakar wants to merge 7 commits intomrousavy:mainfrom
Conversation
…tup to avoid JS module access crash
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
added 2 commits
November 1, 2025 10:41
…ion-camera into fix/camera-device-init-order
|
Someone is attempting to deploy a commit to the mrousavy's Team Team on Vercel. A member of the Team first needs to authorize it. |
|
@mrousavy could you please check this? The current RNVC 4.7.2 is crashing production builds right and left. Thanks a lot! |
|
This is most likely resolved with #3623 (comment) by updating to https://github.com/mrousavy/react-native-vision-camera/releases/tag/v4.7.3 I think this one can be closed. |
…bubakar/react-native-vision-camera into fix/camera-device-init-order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
IllegalStateException: Tried to access a JS module before the React instance was fully set upon Android when using VisionCamera.
The crash occurs because
sendAvailableDevicesChangedEvent()is called from theinit {}blockbefore
initialize()has been invoked by React Native, meaninggetJSModule()is not yet safe to call.Changes
init {}toinitialize().AvailabilityCallbackonly after React instance is ready.Reproduction Steps
initialize()is called.Test Plan