Repository navigation
Add s3 client plugin - #1039
Add s3 client plugin#1039
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 74.94% 75.08% +0.14%
==========================================
Files 184 185 +1
Lines 37795 37900 +105
Branches 2565 2565
==========================================
+ Hits 28324 28457 +133
+ Misses 8548 8520 -28
Partials 923 923 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pavlis
left a comment
There was a problem hiding this comment.
Changes I see all look sensible. Grateful to have an AI to create the pytest functions,. I had no idea how to do that. What it creates seems reasonable.
|
Thought about merging this but maybe we need a rough documentation page first. On the other hand, putting this in the master will allow us to test it more easily and cleanly. That may be needed to write an effective user manual page anyway. What do you think @wangyinz ? |
|
@wangyinz maybe we should use a simpler name for this module? We could use just "s3.py" and add other functionality to this module directly, but it would probably be better to keep this organization centered on usage of a client but shorten the name to something like "s3client.py". I'll let you decide as I'm not at all sure which is better or if it even matters. |
|
I think we could merge it and add the docs later after testing more on it. For the names, I don't have a strong preference. If had to pick, I guess s3client makes more sense. (somehow github stop sending me notice on messages like these... sorry for ignoring it earlier) |
|
I think I will go ahead and change the module name. s3client makes more sense. If I figure out how to do that I'll do it and merge this pull request. |
The old name of s3_worker_plugin for the module was misleading. s3client is more descriptive because the module contains the fetch_s3_client function and not just the plugin code.
Fix a dumb mistake. After I changed the module name I neglected to change the import line for the test code for that module.
This branch initiates creating a standard interface to Amazon S3 for mspass for both serial and parallel workflows. There is work to be done before we merge it, but this adds these features:
I tested the GeoLab and Anonymous versions on GeoLab and both work there for a simple test. Most lacking is a pytest suite to fully exercise this new code. An additional glaring deficiency is no documentation for this new feature in docs. There are some subtle issues we will need to explain for using this we must document before we release the world on this feature.