Repository navigation
Keep rotation state coherent for the downward-axis case - #895
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
==========================================
+ Coverage 71.28% 71.33% +0.04%
==========================================
Files 180 181 +1
Lines 35475 35554 +79
Branches 2510 2523 +13
==========================================
+ Hits 25289 25362 +73
- Misses 9286 9288 +2
- Partials 900 904 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 05:56
wangyinz
marked this pull request as ready for review
August 14, 2026 15:39
wangyinz
force-pushed
the
codex/issue-852-rotation-state
branch
from
August 22, 2026 06:15
c2b29a4 to
00cca0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #852
Summary
theta == pidownward-axis shortcut non-cardinal and orthogonal after applying its sample/matrix transformrotate_to_standardto execute the inverse orthogonal transform instead of returning earlyValidation
py_compile, andgit diff --check: passedIndependent agent review
A different agent re-read #852, independently rebuilt Release and bindings, inspected samples/matrix/flags and the full restored object state, performed the remove-and-restore red proof, and returned REVIEW PASS with no blocker. No merge was performed.