Skip to content

Keep rotation state coherent for the downward-axis case - #895

Merged
wangyinz merged 1 commit into
masterfrom
codex/issue-852-rotation-state
Aug 22, 2026
Merged

wangyinz merged 1 commit into
masterfrom
codex/issue-852-rotation-state

Conversation

@wangyinz

Copy link
Copy Markdown
Member

Fixes #852

Summary

  • mark the theta == pi downward-axis shortcut non-cardinal and orthogonal after applying its sample/matrix transform
  • allow rotate_to_standard to execute the inverse orthogonal transform instead of returning early
  • add Release-safe native and Python binding regressions for theta 0, pi/2, and pi plus complete pi round-trip restoration

Validation

  • Release full build: passed
  • CTest: 13/13 passed
  • rebuilt utility/seismic bindings, confirmed loaded from the isolated review tree: 7/7 related tests passed
  • baseline-red proof: temporarily removing the two state assignments makes both native and binding tests fail at the pi cardinal assertion
  • clang-format, Black, py_compile, and git diff --check: passed

Independent agent review

A different agent re-read #852, independently rebuilt Release and bindings, inspected samples/matrix/flags and the full restored object state, performed the remove-and-restore red proof, and returned REVIEW PASS with no blocker. No merge was performed.

@codecov

codecov Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.25000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.33%. Comparing base (431f962) to head (00cca0c).

Files with missing lines Patch % Lines
cxx/test/tcs/test_rotation_state.cc 85.89% 6 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #895      +/-   ##
==========================================
+ Coverage   71.28%   71.33%   +0.04%     
==========================================
  Files         180      181       +1     
  Lines       35475    35554      +79     
  Branches     2510     2523      +13     
==========================================
+ Hits        25289    25362      +73     
- Misses       9286     9288       +2     
- Partials      900      904       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyinz
wangyinz marked this pull request as draft August 14, 2026 05:56
@wangyinz
wangyinz marked this pull request as ready for review August 14, 2026 15:39
@wangyinz
wangyinz force-pushed the codex/issue-852-rotation-state branch from c2b29a4 to 00cca0c Compare August 22, 2026 06:15
@wangyinz
wangyinz merged commit 91e4f09 into master Aug 22, 2026
18 checks passed
@wangyinz
wangyinz deleted the codex/issue-852-rotation-state branch August 22, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep rotation-state flags coherent for the downward-axis case

1 participant