Skip to content

Fix WindowData padding and time-shift handling - #906

Merged
wangyinz merged 2 commits into
masterfrom
codex/issue-859-window-padding
Aug 22, 2026
Merged

wangyinz merged 2 commits into
masterfrom
codex/issue-859-window-padding

Conversation

@wangyinz

Copy link
Copy Markdown
Member

Fixes #859.

Summary

  • apply t0shift exactly once to both the requested and comparison windows
  • reject reversed autopad windows and non-finite/non-positive sample intervals before allocation or mutation
  • preserve one-sample equal-endpoint windows and normalize MsPASSError construction

Verification

  • focused and existing window tests: 39 passed
  • independent baseline check: 18 contract failures before the fix
  • independent agent review: PASS, zero blockers
  • Black, py_compile, and git diff --check: passed

This PR is ready for human review. It must not be merged automatically.

@codecov

codecov Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 71.30%. Comparing base (431f962) to head (8845e4e).

Files with missing lines Patch % Lines
python/mspasspy/algorithms/window.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #906      +/-   ##
==========================================
+ Coverage   71.28%   71.30%   +0.01%     
==========================================
  Files         180      180              
  Lines       35475    35489      +14     
  Branches     2510     2510              
==========================================
+ Hits        25289    25304      +15     
+ Misses       9286     9285       -1     
  Partials      900      900              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyinz
wangyinz marked this pull request as draft August 14, 2026 05:57
@wangyinz
wangyinz marked this pull request as ready for review August 14, 2026 15:41
@wangyinz
wangyinz force-pushed the codex/issue-859-window-padding branch from c07457e to 8845e4e Compare August 22, 2026 06:13
@wangyinz
wangyinz merged commit f8f1600 into master Aug 22, 2026
18 checks passed
@wangyinz
wangyinz deleted the codex/issue-859-window-padding branch August 22, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply WindowData padding and time shifts exactly once

1 participant