Skip to content

Harden regularize_sampling grid validation - #907

Merged
wangyinz merged 1 commit into
masterfrom
codex/issue-870-regularize-sampling
Aug 22, 2026
Merged

wangyinz merged 1 commit into
masterfrom
codex/issue-870-regularize-sampling

Conversation

@wangyinz

Copy link
Copy Markdown
Member

Fixes #870.

Summary

  • validate Nsamp and the expected sample interval before scanning or mutating an ensemble
  • use the documented half-sample cutoff and pre-scan every live member so abort mode is atomic
  • in non-abort mode, kill and log each invalid member exactly once and mark an all-invalid ensemble dead
  • normalize the adjacent sort_ensemble fatal exception contract

Verification

  • new and existing seismic utility tests: 43 passed
  • exact baseline contract run: 26 failed, 10 passed
  • independent agent review: PASS, zero blockers
  • Black, py_compile, and git diff --check: passed

This PR is ready for human review. It must not be merged automatically.

@codecov

codecov Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.29%. Comparing base (431f962) to head (d323533).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
+ Coverage   71.28%   71.29%   +0.01%     
==========================================
  Files         180      180              
  Lines       35475    35483       +8     
  Branches     2510     2510              
==========================================
+ Hits        25289    25299      +10     
+ Misses       9286     9284       -2     
  Partials      900      900              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wangyinz
wangyinz marked this pull request as draft August 14, 2026 05:57
@wangyinz
wangyinz marked this pull request as ready for review August 14, 2026 15:41
@wangyinz
wangyinz force-pushed the codex/issue-870-regularize-sampling branch from 7f04b77 to d323533 Compare August 22, 2026 06:13
@wangyinz
wangyinz merged commit 4aab918 into master Aug 22, 2026
18 checks passed
@wangyinz
wangyinz deleted the codex/issue-870-regularize-sampling branch August 22, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Close regularize_sampling invalid-grid and abort/kill behavior

1 participant