Repository navigation
Harden EstimateBandwidth frequency bounds - #920
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 70.51% 70.63% +0.12%
==========================================
Files 176 177 +1
Lines 35094 35193 +99
Branches 2498 2503 +5
==========================================
+ Hits 24745 24860 +115
+ Misses 9449 9430 -19
- Partials 900 903 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Draft decision required (renewed review) A signal-processing owner must define smoothing behavior at spectral boundaries and the exact threshold-equality convention. This PR stays draft until the selected policy is documented and validated by an independent synthetic passband oracle rather than by reproducing NumPy's implementation. |
6f907e7 to
f0dcade
Compare
|
Maintainer decision implemented: smoothing uses a truncated, renormalized moving window containing only real spectral bins, and the passband is strictly SNR > threshold (equality is outside). Independent edge and equality oracles pass. The former scientific blocker is resolved. This PR is temporarily stacked on #918 and is now Ready. |
20c3903 to
878d300
Compare
f0dcade to
1497409
Compare
1497409 to
eb87c06
Compare
eb87c06 to
7cbed89
Compare
Fixes #856.
Maintainer-approved behavior
SNR > threshold; a bin equal to the threshold is outside the passband and is returned as the boundary bin.Verification
py_compile, andgit diff --check: passed