Repository navigation
Persist GridFS storage mode during waveform migration - #953
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #953 +/- ##
==========================================
+ Coverage 74.53% 74.55% +0.01%
==========================================
Files 183 183
Lines 36535 36544 +9
Branches 2540 2540
==========================================
+ Hits 27232 27246 +14
+ Misses 8395 8390 -5
Partials 908 908 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
wangyinz
marked this pull request as draft
August 14, 2026 06:01
wangyinz
marked this pull request as ready for review
August 14, 2026 15:42
wangyinz
force-pushed
the
codex/issue-813-storage-mode
branch
from
August 26, 2026 05:44
5b3a3f1 to
0a952b8
Compare
Member
Author
|
Independent compatibility audit complete on the current #955/#1002 commit/rollback path. File storage remains authoritative beside a stale |
wangyinz
force-pushed
the
codex/issue-813-storage-mode
branch
from
August 26, 2026 06:52
deb36b1 to
6a00a1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage_mode="gridfs"in the waveform document whenupdate_datamigrates samples from file storagestorage_mode="file"as authoritative even when an earlier failed migration left a stalegridfs_idread_datapathRoot cause
Database.update_datachanged the in-memory object and wrote new samples to GridFS, but did not persiststorage_mode. The first repair recognized only pristine file documents without agridfs_id; it therefore could not recover the mixedstorage_mode=file + stale gridfs_idstate produced by the original bug. Using the normal overwrite path for that state would also delete the pre-existing GridFS object before the waveform reference became durable.Validation
TestDatabase::test_update_data: 13 passedpy_compile, andgit diff --check: passedThis remains a draft pending the repository-wide scientific/API re-audit.
Fixes #813