Repository navigation
Fix inventory location grouping and lookup - #962
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 73.45% 73.44% -0.01%
==========================================
Files 182 182
Lines 36162 36160 -2
Branches 2532 2532
==========================================
- Hits 26562 26559 -3
- Misses 8695 8696 +1
Partials 905 905 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Human decision required: channels sharing one net/sta/loc can have conflicting geometry, so the current last-channel-wins result is order-dependent. Recommendation: keep exact per-channel metadata; create one site with the union time interval; use channel geometry only when all channels agree, otherwise use Station-level coordinates and emit one warning. The alternative is to reject the conflicting site group. This PR remains Draft pending that choice. |
3f3e456 to
836f8fa
Compare
|
Maintainer decision implemented. Each channel retains its exact StationXML metadata; each net/sta/loc produces one site spanning the union channel interval; agreeing channel geometry defines the site, while conflicting geometry falls back to Station coordinates with one warning. Explicit-location duplicate lookup remains Invalid. No human behavior decision remains; this PR is ready after final CI. |
Summary
Nonefor zero explicit-location matches, the document for one match, andMsPASSError(Invalid)for ambiguous duplicates.This PR does not define or migrate the persistent Inventory representation; #989 owns that codec and its backward-compatible readers.
Validation
git diff --checkpass.Closes #824